sensu-plugins / sensu-plugins-kubernetes

Sensu plugins for Kubernetes
http://sensu-plugins.io
MIT License
28 stars 36 forks source link

Adds ability to explicitly include namespaces #37

Closed Simulalex closed 7 years ago

Simulalex commented 7 years ago

Pull Request Checklist

Is this in reference to an existing issue? no

General

New Plugins

Purpose

Adds the ability to explicitly include namespaces (rather than just excluding them) in check-kube-pods-pending/restarting/running. This is useful in situations where (for example) changes to a feature branch are deployed to their own, individual namespace. In that case we're only really interested in monitoring the health of pods deployed to the "master" or "pre-production" namespaces and not those in the "my-work-in-progress" namespace.

Known Compatibility Issues

This change will remove support for Ruby 2.0, requiring >= Ruby 2.1

Simulalex commented 7 years ago

So, I haven't used travis-ci before, but I think the failing check has to do with a transitive dependency of kubeclient. It depends on a gem named "http" which in turn depends on "addressible". It looks like a new version of addressible was released today (https://rubygems.org/gems/addressable/versions/2.5.2) which depends on public_suffix < 4.0, >= 2.0.2, but public_suffix 3.0.0 requires ruby >= 2.1 (https://rubygems.org/gems/public_suffix/versions/3.0.0)

I don't know enough to know the right way to go about fixing this, I just wanted to share what I found to (hopefully) save someone some time.

majormoses commented 7 years ago

@Simulalex that makes sense to me. In this case ruby 2.0 is technically EOL anyways so I am in favor here of dropping support and testing for it. This does technically make it a breaking change so please call that out in the CHANGELOG. The locations you need to edit are:

Let me know if you need anymore help.

Simulalex commented 7 years ago

Sorry, I didn't see the "Breaking Change" type in the change log docs, but I really like that idea.

majormoses commented 7 years ago

Ya I need to officially write that up somewhere but its something we started doing recently.

majormoses commented 7 years ago

released: https://rubygems.org/gems/sensu-plugins-kubernetes/versions/2.0.0