Fix for #39 - Githubissues

sensu-plugins / sensu-plugins-kubernetes

Sensu plugins for Kubernetes

http://sensu-plugins.io

MIT License

28 stars 36 forks source link

Fix for #39 #42

Closed AgarFu closed 6 years ago

AgarFu commented 6 years ago

Pull Request Checklist

This PR fixes issue #39

General

[x] Update Changelog following the conventions laid out on Keep A Changelog
[x] Update README with any necessary configuration snippets
[X] Binstubs are created if needed
[X] RuboCop passes
[X] Existing tests pass

New Plugins

[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

majormoses commented 6 years ago

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

AgarFu commented 6 years ago

I'll create a test for it, I'm happy reverting the changelog changes

AgarFu commented 6 years ago

@khilawar4

Please take a look at this bugfix.

majormoses commented 6 years ago

I am currently on vacation and will review this again when I have some time.

majormoses commented 6 years ago

Sorry for the long delay I was on vaction, started a new job and had other things going on as well so this dropped off my radar.

majormoses commented 6 years ago

Sorry if I was not clear we actually want you to include the changelog entry just not version and date it, it should remain under ### [Unreleased] I will add that back in before releasing.

majormoses commented 6 years ago

released: https://rubygems.org/gems/sensu-plugins-kubernetes/versions/3.0.1

AgarFu commented 6 years ago

Awesome, thx!