sensu-plugins / sensu-plugins-kubernetes

Sensu plugins for Kubernetes
http://sensu-plugins.io
MIT License
28 stars 36 forks source link

Misleading output text in the check-kube-service-available.rb check #89

Open jakerobb opened 4 years ago

jakerobb commented 4 years ago

If a checked service is not ready for longer than the allowable pending seconds, the resulting critical message reads:

All services are not ready: (list of services here)

This is misleading. It sounds like ALL services are not ready; i.e., nothing is ready. A catastrophic failure.

This should instead read:

Not all services are ready: (list of services)

or

Some services are not ready: (list of services)

or, depending on the count:

(name of service) service is not ready. (number) services are not ready: (list of services)

Feedback appreciated on which would be preferred; I like the last one best, myself. I'll give it a few days to gather opinions on that and then submit a PR if someone else doesn't beat me to it.