sensu-plugins / sensu-plugins-kubernetes

Sensu plugins for Kubernetes

http://sensu-plugins.io

MIT License

28 stars 36 forks source link

Fix a bug in check-kube-pods-running.rb #98

Closed ttarczynski closed 4 years ago

ttarczynski commented 4 years ago

Pull Request Checklist

/fix #68

General

[x] Update Changelog following the conventions laid out at here
[x] Update README with any necessary configuration snippets
[x] Binstubs are created if needed
[ ] RuboCop passes
[ ] Existing tests pass

New Plugins

Purpose

It's a bug fix for:

68 – check-kube-pods-running.rb - no implicit conversion of nil into String

The "no implicit conversion of nil into String" error occurs when there are PODs in Pending state

Known Compatibility Issues

ttarczynski commented 4 years ago

The tests are failing. But I think it's due to reasons unrelated to this change.

There seems to be a dependency issue:

Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    bundler (~> 1.7)
  Current Bundler version:
    bundler (2.1.2)
This Gemfile requires a different version of Bundler.

majormoses commented 4 years ago

The tests are failing. But I think it's due to reasons unrelated to this change.

There seems to be a dependency issue:
Bundler could not find compatible versions for gem "bundler":
  In Gemfile:
    bundler (~> 1.7)
  Current Bundler version:
    bundler (2.1.2)
This Gemfile requires a different version of Bundler.

Yes it's definitely unrelated. I will look to fix that when I can. it should just be a matter of installing a newer bundler in travis / update the gemspec but you never know until you hop into it.

majormoses commented 4 years ago

I did a bit of cleanup to get CI working in #100 and am working on cutting a release shortly.

majormoses commented 4 years ago

released: https://rubygems.org/gems/sensu-plugins-kubernetes/versions/4.0.1

majormoses commented 4 years ago

Thanks for the fix