prepping for Sensu Go. - Githubissues

sensu-plugins / sensu-plugins-logs

This plugin provides native instrumentation for monitoring log files or system logs via journald for regular expressions, and a Sensu handler for logging Sensu events to log files.

http://sensu-plugins.io

MIT License

8 stars 31 forks source link

prepping for Sensu Go. #42

Closed jspaleta closed 5 years ago

jspaleta commented 5 years ago

Pull Request Checklist

Is this in reference to an existing issue? closes: #41 #40 #39 #38 #42

General

[X] Update Changelog following the conventions laid out here
[X] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[X] RuboCop passes
[X] Existing tests pass

New Plugins

[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here

Purpose

Sensu Go Enablement
Update development deps to latest versions

Known Compatibility Issues

majormoses commented 5 years ago

have you taken a look at the 2 failures, they seem legit, I will try to spend some time later looking at it and figuring out why it breaks on older than ruby 2.5 versions.

jspaleta commented 5 years ago

I think the failures are the result of the change i made to satisfy updated rubocup changing > 0 to .is_positive? fails on older rubies. Need to add an exception to rubocop

jspaleta commented 5 years ago

Build failures fixed with adjustment to rubocop rules. Needed to disable Style/NumericPredicate which was enforcing use of positive? to replace > 0 and not compatible with older rubies.

majormoses commented 5 years ago

released: https://rubygems.org/gems/sensu-plugins-logs/versions/3.0.0