search

sensu-plugins / sensu-plugins-memory-checks

This plugin provides native memory instrumentation for monitoring and metrics collection, including: memory usage via `free` and `vmstat`, including metrics. Note that this plugin may have cross-platform issues.
http://sensu-plugins.io
MIT License
15 stars 50 forks source link

gcc required due to vmstat add_runtime_dependency #22

Closed jpcarey closed 8 years ago

jpcarey commented 8 years ago

the add_runtime_dependency for vmstat requires that the system this gem will be deployed to must have a gcc compiler in order to compile the vmstat binary. This is an annoying dependency, and is required even if the vmstat package is available on the system.

https://github.com/sensu-plugins/sensu-plugins-memory-checks/blob/master/sensu-plugins-memory-checks.gemspec#L44

analytically commented 8 years ago

@mattyjones

mattyjones commented 8 years ago

@jpcarey @analytically Sorry for the late response. I agree with it being a pia, and would be open to pulling it if a better solution is known otherwise I am not sure what the best course of action is.

confiq commented 8 years ago

It's kinda problematic dependency... Perhaps moving vmstat to different plugin might be right solution?

apt-get install build-essential in debian will enable installing memory-checks plugin...

analytically commented 8 years ago

I'll accept a PR removing the dependency and detailing the vmstat installation for check-ram.rb. Would it also be possible to add a check to check-ram.rb?

majormoses commented 8 years ago

@analytically sorry I must have missed the email. I have yet to find a better solution with a ruby implementation and I dont think we can get around that. What I suppose we could do is make it a development dependency, add a check to the plugin, and detail the unique install instructions...

analytically commented 8 years ago

Sounds good! And add explanation in CAPITAL in plugin description...

majormoses commented 8 years ago

https://github.com/sensu-plugins/sensu-plugins-memory-checks/pull/25

majormoses commented 8 years ago

@jpcarey let me know if the pr fixes your issue