search

sensu-plugins / sensu-plugins-memory-checks

This plugin provides native memory instrumentation for monitoring and metrics collection, including: memory usage via `free` and `vmstat`, including metrics. Note that this plugin may have cross-platform issues.
http://sensu-plugins.io
MIT License
15 stars 50 forks source link

memory-check.sh thresholds should not default to zero #59

Closed peter-halligan closed 7 years ago

peter-halligan commented 7 years ago

As other check plugins within the repo have defaults which will send an alert. There should be a default for memory-check.sh or an error which prevents the check running without defined thresholds. The lack of thresholds will continue to show a healthy status until the system falls over. Even an arbitrary Threshold which will raise an alert seems better than none.

majormoses commented 7 years ago

@peter-halligan would you be willing to submit a pr for this?

EslamElHusseiny commented 7 years ago

I've addressed this issue in this PR

majormoses commented 7 years ago

@EslamElHusseiny thanks I reviewed, some minor changes and it looks good

majormoses commented 7 years ago

fixed per #62