sensu-plugins / sensu-plugins-memory-checks

This plugin provides native memory instrumentation for monitoring and metrics collection, including: memory usage via `free` and `vmstat`, including metrics. Note that this plugin may have cross-platform issues.
http://sensu-plugins.io
MIT License
15 stars 50 forks source link

Code refactor using only /proc/meminfo #60

Closed alexwbaule closed 7 years ago

alexwbaule commented 7 years ago

Pull Request Checklist

Is this in reference to an existing issue? NO

General

New Plugins

Purpose

Refactoring the code, removing all bash script and dependencies from other gems, using information from /proc/meminfo.

Known Compatablity Issues

Breaks all non linux systems.

majormoses commented 7 years ago

Thank you for your contribution! Unfortunately this breaks too many systems by removing vmstat (which if you dont run that check you do not need the dependency on gcc anymore). Can you please break up your changes into smaller PRs so they are easier to review? As these are full rewrites could you please add unit tests?

majormoses commented 7 years ago

closing do to lack of response of code review and its breaking nature. I really would like to see many of these converted and am open to this being re-opened either here or on another pr/issue.