Closed alexwbaule closed 7 years ago
Thank you for your contribution! Unfortunately this breaks too many systems by removing vmstat (which if you dont run that check you do not need the dependency on gcc anymore). Can you please break up your changes into smaller PRs so they are easier to review? As these are full rewrites could you please add unit tests?
closing do to lack of response of code review and its breaking nature. I really would like to see many of these converted and am open to this being re-opened either here or on another pr/issue.
Pull Request Checklist
Is this in reference to an existing issue? NO
General
[ ] Update Changelog following the conventions laid out on Keep A Changelog
[ ] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[ ] RuboCop passes
[ ] Existing tests pass
New Plugins
[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here
Purpose
Refactoring the code, removing all bash script and dependencies from other gems, using information from /proc/meminfo.
Known Compatablity Issues
Breaks all non linux systems.