Open parinapatel opened 6 years ago
do you need any help with working through the rubocop issues?
Looks like we need a reabse. Let me know if you need any help working through CI issues.
@parin921996 any chance you plan on coming back to this?
@majormoses I have kinda lost track of this one , i will try to fix it by this weekend .
@majormoses Hey I have Fixed the issue , I will create new PR for any new metrics introduced in mongo 3.4 and above.
Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.
@parin921996 any chance you have some systems to test https://github.com/sensu-plugins/sensu-plugins-mongodb/pull/55 with? I'd really like to see both of these over the line.
@parin921996 any chance you have some systems to test #55 with? I'd really like to see both of these over the line.
I dont have any replica set running locally..
Pull Request Checklist
Is this in reference to an existing issue?
General
[x] Update Changelog following the conventions laid out here
[ ] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[x] RuboCop passes
[x] Existing tests pass
New Plugins
[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here
Purpose
Known Compatibility Issues