check-ping false positives

AirCombat commented 8 years ago

Check-ping gives constant false positives. I ping a number of servers on a number of different networks including 8.8.8.8

The checks fail and then the following check always succeeds. The check that fails always says none successful. When pinging during this period from bash, no packets are lost.

CheckPING CRITICAL: ICMP ping unsuccessful for host: 10.1.8.1 (successful: 0/20) CheckPING CRITICAL: ICMP ping unsuccessful for host: 10.1.8.2 (successful: 0/3)

The following is an example where sensu gave a critical and then a ok alert during the pings below:

[root@sensu ~]# ping 10.1.8.1 -i 0.1 -c 2000 --- 10.1.8.1 ping statistics --- 2000 packets transmitted, 2000 received, 0% packet loss, time 200026ms rtt min/avg/max/mdev = 0.185/0.330/0.948/0.202 ms

Thanks

eheydrick commented 8 years ago

Hi @AirCombat, what is the platform and full check command you are running? Trying to repro but so far unable to.

eheydrick commented 8 years ago

Were you able to dig more?

AirCombat commented 8 years ago

Hi,

Apologies for the slow response.

    "Ping_HG_Router": {
      "command": "check-ping.rb -h 1.1.1.1 -c 8 -W 0.1 -C 0 -T 10",
      "interval": 175,
        "handlers": ["OnCallSupport"],
      "standalone": true
    }

This is on CentOS 7.2 (1511), ruby 2.3.0p0, Sensu 0.25

We tried to configure it to make it extremely unsensitive to no avail

kai101 commented 8 years ago

the issue is on 3103dc3e3b147cc014bbbff1c868e7d785ede81f

please fix.

eheydrick commented 8 years ago

@AirCombat can you try @kai101's fix in #41 that was just merged to master. If it looks good I'll cut a new release.

eheydrick commented 8 years ago

Released in 1.1.0.

sensu-plugins / sensu-plugins-network-checks

check-ping false positives #34