search

sensu-plugins / sensu-plugins-network-checks

This plugin provides native network instrumentation for monitoring and metrics collection, including: hardware, TCP response, RBLs, whois, port status, and more.
http://sensu-plugins.io
MIT License
30 stars 76 forks source link

Use Timeout.timeout not deprecated Object#timeout. #35

Closed ab closed 8 years ago

ab commented 8 years ago

From ruby 2.3.0, use of Object#timeout prints a deprecation warning:

Object#timeout is deprecated, use Timeout.timeout instead
SegFaultAX commented 8 years ago

LGTM! We're also suffering from this annoying deprecation warning. :)

:shipit: 💩 :trollface:

mattyjones commented 8 years ago

@ab @SegFaultAX

Can one of you confirm this does not break 2.1 and 2.2, if this is the case I will merge and release.

SegFaultAX commented 8 years ago

@mattyjones I can confirm that Timeout#timeout has been valid since at least 1.8.7.

eheydrick commented 8 years ago

Thanks!