search

sensu-plugins / sensu-plugins-network-checks

This plugin provides native network instrumentation for monitoring and metrics collection, including: hardware, TCP response, RBLs, whois, port status, and more.
http://sensu-plugins.io
MIT License
30 stars 76 forks source link

Add ability to specify alert level in check-ports.rb #64

Open thisiskseniab opened 6 years ago

thisiskseniab commented 6 years ago

check-ports.rb is a great tool, but it would be great to have an ability to specify "warning" as opposed to "critical" alert level for it, similarly as in check-ports-bind.rb and check-ports-nmap.rb.

Evesy commented 6 years ago

Happy to put in a PR for this one as I'd like this too, looks like it originally existed but got lost at some point: https://github.com/sensu-plugins/sensu-plugins-network-checks/commit/2d5d981ba1467ae433361f43107fc52075abfca8

@majormoses If you could spare a moment, I can't figure out what unless config[:crit_message] is for here https://github.com/sensu-plugins/sensu-plugins-network-checks/blob/master/bin/check-ports.rb#L102 -- Seems like it may be redundant but wanted to double check before I put something together

majormoses commented 6 years ago

@Evesy sorry this got lost in the sea of my github notifications. Ya that needs to be removed, I am not sure its worth the git archaeology to determine when, where, and why it changed lets just remove it.

If we were to implement a new option we would probably want it to be for a specific condition rather than catch all as not all errors are equal. For example we have one for redis for connection failures here: https://github.com/sensu-plugins/sensu-plugins-redis/blob/3.0.1/lib/redis_client_options.rb#L71-L75 as depending on the check it has a different meaning. If the check is meant to determine the health of redis you probably want that as a crit where other places you might want an unknown as you already have the crit from the one check and can help with improving the signal to noise ratio.