search

sensu-plugins / sensu-plugins-network-checks

This plugin provides native network instrumentation for monitoring and metrics collection, including: hardware, TCP response, RBLs, whois, port status, and more.
http://sensu-plugins.io
MIT License
30 stars 76 forks source link

bug fix for warn and crit values #82

Closed aww-yiss closed 6 years ago

aww-yiss commented 6 years ago

Fix for https://github.com/sensu-plugins/sensu-plugins-network-checks/issues/81

Corrects warning and critical logic for number of days until expiration

csabo commented 6 years ago

Looks good, nice catch!

majormoses commented 6 years ago

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

majormoses commented 6 years ago

Did a bit of git archaeology while waiting for CI. The bug was introduced here: https://github.com/sensu-plugins/sensu-plugins-network-checks/commit/8b06cdaaa1c6a77ad72e5c5995841b3c6e7d1f1e#diff-56550700c877f2a3e27b58702171f4fc and was released in 2.3.0

majormoses commented 6 years ago

released: https://rubygems.org/gems/sensu-plugins-network-checks/versions/3.2.1