search

sensu-plugins / sensu-plugins-opsgenie

Sensu plugins for OpsGenie
http://sensu-plugins.io
MIT License
4 stars 24 forks source link

Convert to extension handler #10

Closed nhooey closed 7 years ago

nhooey commented 8 years ago

Pull Request Checklist

Most of the things from this checklist are missing. I wanted to get some feedback before writing tests and documentation. I'll edit the description as I make progress.

General

This change makes the Sensu OpsGenie run as an Extension Handler, which drastically reduces the amount of CPU used. It also happens to work.

Known Compatablity Issues

It's completely incompatible with the regular handler version, and the script needs to be copied to /etc/sensu/extensions.

nhooey commented 8 years ago

@portertech @rmc3 Do you guys have any suggestions?

nhooey commented 8 years ago

Could someone have a look this pull request and provide any feedback before I fix and write more tests? @tas50 @mattyjones @rmc3 @portertech

eheydrick commented 8 years ago

I think this is really cool. We need to find a better home for extensions, it was decided that extensions should not live within the sensu-plugins org as they are more like core components. Lets discuss with @calebhailey.

luisdalves commented 7 years ago

Hey guys. What happened with this? I'm seeing a lot of deprecated messages in this handler and I think we have some issues but I'm not sure if it is related.

Is there any plan to merge this or an option to fix it?

Thanks

eheydrick commented 7 years ago

Hi @luisdalves, Sensu Extensions have their own home now over at https://github.com/sensu-extensions. Check out https://github.com/sensu-extensions/template for howto create a Sensu Extension.

As for the problems you are seeing, would you mind opening a new issue in this project so we can track it.

nhooey commented 7 years ago

@eheydrick Should I move this extension over?

Has anyone else fixed in since I wrote this pull request?

majormoses commented 7 years ago

@eheydrick can you create the repo over there I do not have access...

eheydrick commented 7 years ago

I don't have access either. @cwjohnston can you create this repo.

agoddard commented 7 years ago

@nhooey @eheydrick @majormoses https://github.com/sensu-extensions/sensu-extensions-opsgenie/pull/1/files cc/ @cwjohnston

majormoses commented 7 years ago

awesome thanks for doing that.

majormoses commented 7 years ago

can we close this?

nhooey commented 7 years ago

I wrote this code, right? Can't see right now.

If it was me, I'll move it to the new repo and close it. On Thu, Jun 1, 2017 at 23:38 Ben Abrams notifications@github.com wrote:

can we close this?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/sensu-plugins/sensu-plugins-opsgenie/pull/10#issuecomment-305680927, or mute the thread https://github.com/notifications/unsubscribe-auth/AAD_sut9TcYJY7j2V_S3RiJRIAZP7Fs1ks5r_4OrgaJpZM4IHmgF .

-- Neil Hooey Remote Contract Software Engineer

Mobile: +33 7 69 86 01 73 Google Voice: +1 347-770-6345 LinkedIn: http://linkedin.com/in/nhooey

majormoses commented 7 years ago

closing per https://github.com/sensu-plugins/sensu-plugins-opsgenie/pull/10#issuecomment-305681169