Closed Castaglia closed 6 years ago
Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.
There are no current/existing tests for this particular plugin, to demonstrate what such preferable test artifacts might be; could you point me in the direction of what you have in mind?
Sure, so the link I put before for testing artifacts talk about testing in the PR processes. I'd either go for a manual test or some integration tests with serverspec
and test-kitchen
. I have wrote a pair of blog posts talking more about plugin testing:
Thanks for the fixes, @majormoses . My Ruby-fu is still pretty weak. :)
No problem I am more than happy to help anyone willing to put in a little effort. I will get the testing framework functional for you.
If it makes you feel any better I am sure your c skills are quite a bit better than mine. I have not written anything in c for a while.
@eheydrick any comments as a user of this? If I don't hear back shortly I will merge this.
The code looks good to me.
Pull Request Checklist
fixes #18
General
[x] Update Changelog following the conventions laid out on Keep A Changelog
[x] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[x] RuboCop passes
[x] Existing tests pass
Purpose
EDIT: Use v2 apis.
Known Compatability Issues
EDIT: drop ruby 2.0 support and testing because it is EOL