sensu-plugins / sensu-plugins-opsgenie

Sensu plugins for OpsGenie
http://sensu-plugins.io
MIT License
4 stars 24 forks source link

Issue #18: Use the Heartbeat v2 API. #21

Closed Castaglia closed 6 years ago

Castaglia commented 6 years ago

Pull Request Checklist

fixes #18

General

Purpose

EDIT: Use v2 apis.

Known Compatability Issues

EDIT: drop ruby 2.0 support and testing because it is EOL

majormoses commented 6 years ago

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

Castaglia commented 6 years ago

There are no current/existing tests for this particular plugin, to demonstrate what such preferable test artifacts might be; could you point me in the direction of what you have in mind?

majormoses commented 6 years ago

Sure, so the link I put before for testing artifacts talk about testing in the PR processes. I'd either go for a manual test or some integration tests with serverspec and test-kitchen. I have wrote a pair of blog posts talking more about plugin testing:

Castaglia commented 6 years ago

Thanks for the fixes, @majormoses . My Ruby-fu is still pretty weak. :)

majormoses commented 6 years ago

No problem I am more than happy to help anyone willing to put in a little effort. I will get the testing framework functional for you.

majormoses commented 6 years ago

If it makes you feel any better I am sure your c skills are quite a bit better than mine. I have not written anything in c for a while.

majormoses commented 6 years ago

@eheydrick any comments as a user of this? If I don't hear back shortly I will merge this.

eheydrick commented 6 years ago

The code looks good to me.

majormoses commented 6 years ago

released: https://rubygems.org/gems/sensu-plugins-opsgenie/versions/4.0.0