Support a Sensu check custom attribute of `alias`, so that Sensu chec…

sensu-plugins / sensu-plugins-opsgenie

Sensu plugins for OpsGenie

http://sensu-plugins.io

MIT License

4 stars 24 forks source link

Support a Sensu check custom attribute of `alias`, so that Sensu chec… #24

Closed Castaglia closed 6 years ago

Castaglia commented 6 years ago

…ks can

specify the OpsGenie event ID value to use.

This is necessary for supporting de-duplication of multiple Sensu alerts, based on a shared/common OpsGenie event ID.

Pull Request Checklist

Is this in reference to an existing issue?

General

[x] Update Changelog following the conventions laid out on Keep A Changelog
[x] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[ ] RuboCop passes
[x] Existing tests pass

New Plugins

[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here

Purpose

Known Compatability Issues

majormoses commented 6 years ago

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

majormoses commented 6 years ago

Seems like a good idea to me, one thought that I was that while it does have some advantages (such as choosing to only dedupe on some handlers) doing it in the handler like this I think that the same could actually be accomplished using proxy formerly known as JIT (Just in Time) clients and optionally round robin subscriptions. Moreso letting you know in case you were not aware these were available. These options landed in sensu well after I needed it and I ended up adding similar concepts via filtering and handlers to dedupe the events.

majormoses commented 6 years ago

released: https://rubygems.org/gems/sensu-plugins-opsgenie/versions/4.1.0