sensu-plugins / sensu-plugins-opsgenie

Sensu plugins for OpsGenie
http://sensu-plugins.io
MIT License
4 stars 24 forks source link

Support setting the OpsGenie alert priority on a per-check basis. #27

Closed Castaglia closed 6 years ago

Castaglia commented 6 years ago

Pull Request Checklist

Is this in reference to an existing issue?

General

New Plugins

Purpose

Known Compatibility Issues

majormoses commented 6 years ago

@Castaglia that seems like a good idea to me, it does raise some questions that I think we should discuss in #28 prior to code review. I look forward to hearing your thoughts especially as a user of opsgenie.

Castaglia commented 6 years ago

Any additional work/thoughts on this PR?

majormoses commented 6 years ago

Sorry will review, easy to lose track of all of these and never enough time.

majormoses commented 6 years ago

@Castaglia checking if you have time to circle back. I see that you will need to rebase to fix conflicts, let me know if you need help with that.

majormoses commented 6 years ago

IMHO, Rubocop's defaults a little too strict.

Can't argue with you there, thats why they expose config and allow inline disables. That being said rubocop has made me a much better developer both in the sense of learning to follow commonly accepted convention and more importantly learn why the rules exist and know when to disagree from an informed stance. If you are talking about long running applications ya a long block is probably a bad idea but in a short lived monitoring script there is less need to worry about such things.

majormoses commented 6 years ago

released: https://rubygems.org/gems/sensu-plugins-opsgenie/versions/4.3.0