search

sensu-plugins / sensu-plugins-pagerduty

This plugin provides a Sensu handler for PagerDuty.
http://sensu-plugins.io
MIT License
20 stars 32 forks source link

Doesn't create incidents when "flapping" #33

Closed sara4dev closed 7 years ago

sara4dev commented 8 years ago

Sensu can generate events with action flapping, and the handler should be able to create incident when events are flapping.

majormoses commented 7 years ago

@saravanakumar-periyasamy You need to update your handler config to change the default behavior of: handle_flapping to true. See here for more info: https://sensuapp.org/docs/0.24/reference/handlers.html#handler-configuration

majormoses commented 7 years ago

just took a look at the code and it does require a minor tweak, I can open a PR for it if you want to do some testing.

majormoses commented 7 years ago

@saravanakumar-periyasamy can you test my change and validate that this combined with the required config change works?

sara4dev commented 7 years ago

@majormoses - code does look good! I have the same change in my code & running for months now. My bad, I did not give the PR for that. Thanks for fixing it!

majormoses commented 7 years ago

@saravanakumar-periyasamy no worries, can you comment on the PR saying you have tested it? This will help it typically get merged faster.

sara4dev commented 7 years ago

tested this code & fixes the issue! Infact I am running this code fix in prod for several months now.

majormoses commented 7 years ago

I meant on the actual PR: https://github.com/sensu-plugins/sensu-plugins-pagerduty/pull/41 as you had already commented here.