adding count by process status

sensu-plugins / sensu-plugins-process-checks

This plugin provides native process instrumentation for monitoring and metrics collection, including: process status, uptime, thread count, and others.

http://sensu-plugins.io

MIT License

20 stars 55 forks source link

adding count by process status #49

Closed alcasim closed 7 years ago

alcasim commented 7 years ago

Pull Request Checklist

Is this in reference to an existing issue?

General

[x] Update Changelog following the conventions laid out on Keep A Changelog
[ ] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[x] RuboCop passes
[x] Existing tests pass

New Plugins

[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here

Purpose

Known Compatablity Issues

majormoses commented 7 years ago

@alcasim thanks for the contribution. I need a testing artifact which while automated tests are preferable as long as we can see something demonstrating its input and output (a gist or screenshot) that works for me.

alcasim commented 7 years ago

Hi @majormoses I couldn't write some testing for this, please find this gist with the output of this new metrics: https://gist.github.com/alcasim/5c8fe93cc9aacee6f6d98647b2354126 I will try to progress adding some automated test to this feature, thanks!

majormoses commented 7 years ago

released: https://rubygems.org/gems/sensu-plugins-process-checks/versions/2.4.0