sensu-plugins / sensu-plugins-sensu

This plugin provides monitoring and metrics for Sensu.
http://sensu-plugins.io
MIT License
12 stars 35 forks source link

check-aggregate.rb options don't work with named aggregates #19

Open ttarczynski opened 7 years ago

ttarczynski commented 7 years ago

When using this with sensu => 0.24.0 (which introduced named aggregates) some options of check-aggregate.rb don't work any more. I think the following options are now broken:

I've tried to fix --output but after looking into the code I've found out that Sensu Aggregates (2.0) API is rewritten from scratch:

I think it makes sense to drop sensu < 0.24 compatibility and provide only options that can work with sensu => 0.24

majormoses commented 6 years ago

At this point we need to get this fixed even if it is a breaking change. As long as we properly call it out in the changelog and the maintainers version it as a major release I am :+1: on dropping the older support.