sensu-plugins / sensu-plugins-sensu

This plugin provides monitoring and metrics for Sensu.
http://sensu-plugins.io
MIT License
12 stars 35 forks source link

Removing brackets that break remediation #51

Closed drhey closed 6 years ago

drhey commented 6 years ago

Pull Request Checklist

This is in reference to issue #50

General

New Plugins

N/A

Purpose

The brackets that were added around subscribers in req.body (within the trigger_remediation method) result in remediation not working. The API call is issued and returns a 202, but further investigation shows that double brackets appear around the subscribers resulting in no remediation being executed on afflicted hosts.

Known Compatibility Issues

None

majormoses commented 6 years ago

@drhey I committed what I was thinking we should do to your fork, if you can test that out and give the :+1: I can merge and release this.

drhey commented 6 years ago

@majormoses Apologies! The holidays got the best of me. I am reviewing your comments/updates and will report back ASAP!

drhey commented 6 years ago

@majormoses Good news! The commit you made works swimmingly. Please feel free to merge and release; and do let me know if I can be of any assistance.

majormoses commented 6 years ago

@drhey Hey I will get this merged and released shortly.

majormoses commented 6 years ago

released: https://rubygems.org/gems/sensu-plugins-sensu/versions/2.4.1

drhey commented 6 years ago

@majormoses Thanks for all of your work on this!!