sensu-plugins / sensu-plugins-slack

Sensu Slack chat handlers

http://sensu-plugins.io

MIT License

30 stars 54 forks source link

Added check return value of 127 and a default color for other values #61

Closed fsniper closed 6 years ago

fsniper commented 6 years ago

Pull Request Checklist

34 Problem with "127" (Unknown) exit codes

General

[x] Update Changelog following the conventions laid out here
[ ] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[x] RuboCop passes
[x] Existing tests pass

New Plugins

[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

majormoses commented 6 years ago

I originally thought the error was being returned back as a 127 indicating that the command is not found. I remember seeing something similar with a different plugin and it was caused while nodes were being deployed and the local script did not exist yet and did not use safe_mode = true. Another reason why it is better to handle the errors properly rather than just saying all 127s are config/unknown issues.

majormoses commented 6 years ago

Thank you for submitting this, as you did not address my comments I am closing this in favor of #62 as it solves it for all non spec compliant status codes.