Unify multichannel handler to use client custom fields

korenDevops commented 6 years ago

Pull Request Checklist

Is this in reference to an existing issue? No

General

[ ] Update Changelog following the conventions laid out here
[ ] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[ ] RuboCop passes
[ ] Existing tests pass

Purpose

Include custom client field in the payload as in the handler-slack.rb handler
It seems that this was also the original intention, otherwise it makes no sense to check the client's fields length ( line 292 )

majormoses commented 6 years ago

Hmm I see your point, I need to review this in greater detail but I am thinking that we should support both allowing it to be set via the client or check. I will try to review this in greater depth tomorrow. I think this is a breaking change as it currently stands.

majormoses commented 5 years ago

@CosmoPennypacker does my feedback make sense?

majormoses commented 5 years ago

@CosmoPennypacker any chance you are gonna get back to this?

korenDevops commented 5 years ago

I don't believe I will, sorry

sensu-plugins / sensu-plugins-slack