search

sensu-plugins / sensu-plugins-slack

Sensu Slack chat handlers
http://sensu-plugins.io
MIT License
30 stars 54 forks source link

fix json in comments #64

Closed lcx closed 6 years ago

lcx commented 6 years ago

if reading the comments from the multichannel file and using the examples in the comments as a starting point one will fail due to the incorrect json.

majormoses commented 6 years ago

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

majormoses commented 6 years ago

As this is a non functional change it has been merged to master but we will not cut a release for it. I will add a changelog entry though.

craigpfeiffer commented 6 years ago

I'd also like to note on this that in the comments for the handler it states

{ "handlers": { "slack": { "channels": { "default": [ "#no-team-alerts" ], "compulsory": [ "#all-alerts" ], } }, ..., } }

i was not able to get that to work and it contradicts what is in the readme. the only way it worked for me was to remove the hash before the channel name.

majormoses commented 6 years ago

@craigpfeiffer lets create a new issue and pull request to address additional changes.