handler-slack-multichannel.rb: several improvements

kali-brandwatch commented 5 years ago

Add support for single channel defined as a string rather than an array (removes the need of having 2 different handlers)
Implement a retry strategy for handling slack api transitient errors (like timeouts). Retries hardcoded to 5 with 10 second timeout, but we should make this a setting
Exits with non zero status on api call errors, to allow sensu-server to catch the output and log it
Deals with non-nagios standard exit codes for checks (0-3), also known as "out of bounds" errors
- Sets the color the same as UNKNOWN
- Displays the exit code as it was returned by the check, for detailed information

Pull Request Checklist

Is this in reference to an existing issue?

General

[ ] Update Changelog following the conventions laid out here
[ ] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[ ] RuboCop passes
[ ] Existing tests pass

New Plugins

[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

majormoses commented 5 years ago

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

kali-brandwatch commented 5 years ago

Ok I will add a commit with the suggested changes here, and mark conversations as resolved accordingly.

majormoses commented 5 years ago

@kali-brandwatch this PR should be updated to reflect that https://github.com/sensu-plugins/sensu-plugins-slack/pull/83 was merged. A rebase is probably in order. I think it would be best to split out the OOB to another PR so we can get the rest of this merged as I don't think we have come to a consensus on how best to proceed on that front.

sensu-plugins / sensu-plugins-slack