sensu-plugins / sensu-plugins-statuspage

Sensu plugins for Statuspage
http://sensu-plugins.io
MIT License
4 stars 7 forks source link

Allow desired component/incident status configuration per check. #4

Closed athal7 closed 7 years ago

athal7 commented 7 years ago

Some users may want to choose what the incident or component status is for warning vs critical on a per-check basis, rather than having it always be major_outage and investigating. This change provides that capability, allows for ignoring of certain cases, and ensures only valid statuses get sent to the statuspage api.

athal7 commented 7 years ago

@eheydrick not sure if you're the right person to ping about this, but I saw that you have recent commits. Let me know if you have any thoughts!

eheydrick commented 7 years ago

Hey @athal7, thanks for the PR. It looks good. Are these changes backwards compatible?

athal7 commented 7 years ago

@eheydrick there are a few minor changes that I thought made a bit more sense but happy to revert those if you think it makes more sense to keep them as they were:

existing

component statuses

warning -> major outage critical -> major outage

incident statuses

warning -> investigating critical -> investigating

new

component statuses

warning -> partial outage critical -> major outage

incident statuses

warning -> identified critical -> identified

eheydrick commented 7 years ago

That's actually OK since we're going to release a new major version anyways to remove Ruby 1.9.3 support. Could you add a blurb to the CHANGELOG about any issues/changes someone would face moving from the existing version.

athal7 commented 7 years ago

@eheydrick updated, let me know if you want any more changes.

eheydrick commented 7 years ago

👍 Thanks!

athal7 commented 7 years ago

Thank you!

eheydrick commented 7 years ago

These changes are in 1.0.0, now live on rubygems.