Closed athal7 closed 7 years ago
@eheydrick not sure if you're the right person to ping about this, but I saw that you have recent commits. Let me know if you have any thoughts!
Hey @athal7, thanks for the PR. It looks good. Are these changes backwards compatible?
@eheydrick there are a few minor changes that I thought made a bit more sense but happy to revert those if you think it makes more sense to keep them as they were:
warning -> major outage critical -> major outage
warning -> investigating critical -> investigating
warning -> partial outage critical -> major outage
warning -> identified critical -> identified
That's actually OK since we're going to release a new major version anyways to remove Ruby 1.9.3 support. Could you add a blurb to the CHANGELOG about any issues/changes someone would face moving from the existing version.
@eheydrick updated, let me know if you want any more changes.
👍 Thanks!
Thank you!
Some users may want to choose what the incident or component status is for warning vs critical on a per-check basis, rather than having it always be
major_outage
andinvestigating
. This change provides that capability, allows for ignoring of certain cases, and ensures only valid statuses get sent to the statuspage api.