Add basic proxy support - Githubissues

sensu-plugins / sensu-plugins-statuspage

Sensu plugins for Statuspage

http://sensu-plugins.io

MIT License

4 stars 7 forks source link

Add basic proxy support #5

Closed drhey closed 7 years ago

drhey commented 7 years ago

Pull Request Checklist

Is this in reference to an existing issue?

Yes. It's in reference to at least 3 requests for proxy support (mine included). Although, I am not sure if the others require proxy username and password support - it would be trivial for me to add, but I cannot validate as I don't require that functionality at the moment.

General

[ ] Update Changelog following the conventions laid out on Keep A Changelog
[X] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[ ] RuboCop passes
[ ] Existing tests pass

New Plugins

[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here

Purpose

Add ability to use a this plugin behind a proxy

Known Compatibility Issues

drhey commented 7 years ago

Want to do just a little bit more testing.

drhey commented 7 years ago

My testing confirmed my changes are correct.

majormoses commented 7 years ago

forgot to request a CHANGELOG entry so I will do it.

majormoses commented 7 years ago

released: https://rubygems.org/gems/sensu-plugins-statuspage/versions/1.1.0