bot requirements corrections

sensu-plugins / sensu-plugins-windows

Sensu Windows Plugins

http://sensu-plugins.io

MIT License

22 stars 46 forks source link

bot requirements corrections #108

Closed derekgroh closed 4 years ago

derekgroh commented 4 years ago

Pull Request Checklist

Addresses bot Pull Requests #67 #95 #107

General

[X] RuboCop passes

Purpose

Resolves outstanding bot requirements for updates to rubocop, rake and codeclimate.

derekgroh commented 4 years ago

@majormoses Leaving it for you to merge unless there are any other items to address.

edit - apparently the commit didn't push, sorry for the confusion

majormoses commented 4 years ago

@majormoses Leave it for you to merge to see if there are any other items to address.

Sorry I am not sure I am following, I see my conversations marked as resolved but no code change. Are you wanting me to update the code based on the comments I put?

nixwiz commented 4 years ago

@majormoses can you review and merge now? Once this is done, I'd like to get some of the latest dependencies brought in if they aren't addressed here and then work to add Bonsai support.

majormoses commented 4 years ago

@majormoses can you review and merge now? Once this is done, I'd like to get some of the latest dependencies brought in if they aren't addressed here and then work to add Bonsai support.

Merged, do you want me to cut a release or do you got it?

nixwiz commented 4 years ago

Can you go ahead and cut the release, I'll pick up what I want to do with this next week. Thanks!

majormoses commented 4 years ago

Ya I will get to it over the weekend.