search

sensu-plugins / sensu-plugins-windows

Sensu Windows Plugins
http://sensu-plugins.io
MIT License
22 stars 46 forks source link

Sensu Plugins For Windows #23

Closed ajeba99 closed 8 years ago

ajeba99 commented 8 years ago

Pull Request Checklist

I come in peace.

Is this in reference to an existing issue? Yes, https://github.com/sensu-plugins/sensu-plugins-windows/issues/15

General

To provide an overall update to the current repo as well as provide Pure Powershell versions of existing Check and Metric plugins.

Known Compatablity Issues

None that I am aware of.

ajeba99 commented 8 years ago

Well yeah it's going to fail. It's not Ruby.

sstarcher commented 8 years ago

could you fix the 3 rubocop lint errors

ajeba99 commented 8 years ago

I fixed the linting errors. But I don't know how to fix the ruby gemspec error. Any assistance would be greatly appreciated.

sstarcher commented 8 years ago

I believe part of the problem is moving things to a sub-folder.

ajeba99 commented 8 years ago

Right, how do I tell the gem spec to search there instead?

sstarcher commented 8 years ago

You can specify a different bin directory, but I don't think that makes sense. You are better off not putting the files into different subdirectories as that's not the point of a bin directory.

ajeba99 commented 8 years ago

So, put all the checks and metrics (whether powershell or ruby) in one directory? That would be difficult for the eye to parse yes?

sstarcher commented 8 years ago

at a minimum put the ruby in the top directory if you want to put ps in a sub directory feel free, but I still believe they should all be at the top level. If not the PATH would have to be configured for the sub directories.