sensu-plugins / sensu-plugins-windows

Sensu Windows Plugins
http://sensu-plugins.io
MIT License
22 stars 46 forks source link

more complete disk check #34

Closed simonsteur closed 7 years ago

simonsteur commented 7 years ago

Although the original check works fine, it stops processing disks as soon as one has a critcal or warning value. Absolutely fine in a single disk setup.

However it is possible that a system has more than one disk and that multiple are in a critical or warning state. This change processes all the disks before sending an exit code, it also provides a more complete output for critical and warning values.

simonsteur commented 7 years ago

Also a change to the cpu load check. The problem being that on multi cpu socket setups the current check doesn't work properly.

Currently the check would return multiple values and trigger alert if a cpu sockets load would go over the specified warning or critical level. By looking at a system counter instead we can get the Total Value of the system load without any big change to the script at all.

eheydrick commented 7 years ago

Thanks.