Apply quotes to the service name

bodgit commented 7 years ago

Pull Request Checklist

This fixes #21 and also stops a space-separated service name from matching other services.

I have to include the following to keep my employers legal team happy:

This contribution is provided 'as is' and without any warranty or guarantee of any kind, express or implied, including in relation to its quality, suitability for a particular purpose or non-infringement. To the extent permitted by law, in no event shall the creator of this contribution be liable for any claim, damage or other liability, whether arising in contract, tort or otherwise, arising out of or in connection with this contribution.

General

[x] Update Changelog following the conventions laid out on Our CHANGELOG Guidelines
[ ] Update README with any necessary configuration snippets
[ ] Binstubs are created if needed
[x] RuboCop passes
[x] Existing tests pass

New Plugins

[ ] Tests
[ ] Add the plugin to the README
[ ] Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

majormoses commented 7 years ago

@bodgit this looks good, can you please provide a testing artifact as described here: https://github.com/sensu-plugins/community/blob/master/PULL_REQUEST_PROCESS.md#7-testing-artifacts

bodgit commented 7 years ago

If only there were some existing tests to use for inspiration... :stuck_out_tongue_winking_eye:

majormoses commented 7 years ago

@bodgit especially for windows...for anything else I would have pointed you at https://github.com/sensu-plugins/sensu-plugins-dcos for inspiration as that is what we are slowly trending towards.

bodgit commented 7 years ago

I was going to ask if this could make it out as a release but it looks like you're already prepping 2.2.1.

majormoses commented 7 years ago

released: https://rubygems.org/gems/sensu-plugins-windows/versions/2.2.1

sensu-plugins / sensu-plugins-windows