Created new helper for powershell files

sensu-plugins / sensu-plugins-windows

Sensu Windows Plugins

http://sensu-plugins.io

MIT License

22 stars 46 forks source link

Created new helper for powershell files #55

Closed makaveli0129 closed 6 years ago

makaveli0129 commented 6 years ago

Pull Request Checklist

Is this in reference to an existing issue?

General

[x] Update Changelog following the conventions laid out on Our CHANGELOG Guidelines
[x] Update README with any necessary configuration snippets
[x] Binstubs are created if needed
[x] RuboCop passes
[x] Existing tests pass

New Plugins

[x] Tests
[x] Add the plugin to the README
[x] Does it have a complete header as outlined here

Purpose

Known Compatibility Issues

majormoses commented 6 years ago

Thanks for your contribution to Sensu plugins! Without people like you submitting PRs we couldn't run the project. I will review it shortly.

majormoses commented 6 years ago

I will review this again in closer detail but I'd like the docs to indicate that you do not need to use the helper it just is the prefered option @absolutejam any thoughts on this?

makaveli0129 commented 6 years ago

all any update on this PR?

majormoses commented 6 years ago

Sorry I have not looked back at this as I was hoping someone who knew windows and powershell would review this. I am overall :+1: my only concern is that this indicates this is the only method if you update the doc to indicate that this is one of several acceptable methods I am good to merge this.

makaveli0129 commented 6 years ago

@majormoses you should be all set now

majormoses commented 6 years ago

released: https://rubygems.org/gems/sensu-plugins-windows/versions/2.5.0