search

sensu-plugins / sensu-plugins-zfs

Sensu ZFS Plugin
http://sensu-plugins.io
MIT License
3 stars 12 forks source link

Update zpool.rb #28

Open ipaqmaster opened 3 years ago

ipaqmaster commented 3 years ago

's/sudo\ //g'

Pull Request Checklist

Is this in reference to an existing issue? No.

Purpose

Tried this plugin in our sensu environment today and noticed that it was returning "OK" but only after a sudo error on the line above which completely cancelled the script's logic out.

This plugin (At least on zfs-0.8+) runs perfectly fine without sudo and is able to observe all pools and properly report when there's a disk error all without sudo and is working perfectly fine in my environment without needing to configure sudo anymore.

Perhaps this isn't the route you want to go, but I figured I'd share this here as it seems to work best for our environment without sudoing just to check stats any account may access by default or by policy.

Known Compatibility Issues

None discovered yet. Intentionally broke test pool and script detected and threw an error state as expected.

sboyd-m commented 2 years ago

Any chance this gets merged in this decade? We also need this, really don't want to have to bother with a fork