search

sensu / check-disk-usage

MIT License
2 stars 8 forks source link

Add --inode-mode option #12

Open boagg opened 3 years ago

boagg commented 3 years ago

Signed-off-by: Steven Agbo agbosteven@gmail.com

jspaleta commented 3 years ago

Hey, I'm not opposed to inode checking as an option, not sure about -j for the short option.. maybe its best not to give this a short option. This is going to need to be refactored a bit due to other PRs being merged in, so probably not merging this in this week.

jspaleta commented 3 years ago

Hey, Thinking a little more about this.. I think the inode centric functionality might be best as a separate command. The descriptive help text for some of the advanced options is probably going to be really confusing if they have to serve both inode and disk size. It's not a lot of trouble to have separate commands, we can even ship multiple checks in the same asset as part of this repository.

I have to think about it a little bit more to be sure what the correct approach is long term.

jspaleta commented 2 years ago

I'm gonna try to refactor this and get it merged after the magic option gets merged in.

pearsondavid commented 1 year ago

@jspaleta Any update on this please? Being able to monitor inodes would have been extremely useful of late for me.

pearsondavid commented 11 months ago

@jspaleta Any update on this please?

pearsondavid commented 11 months ago

Adding my support for PR to be merged, been running this version in my local env without an issue for the last few weeks.