search

sensu / check-disk-usage

MIT License
2 stars 8 forks source link

implement magic rescaling of thresholds for large filesystems #14

Open jspaleta opened 3 years ago

jspaleta commented 3 years ago

Closes #1

kmf commented 2 years ago

will this be merged?

jspaleta commented 2 years ago

will this be merged?

Let me clean this up and line up specific reviewers. Hopefully next week. I generally don't want to Yolo merge my own PRs unless its a critical bug fix.

jspaleta commented 2 years ago

I already know I need to do a little more work on this before its gonna pass review. I need to add some test coverage. We'll get in probably late next week.

jspaleta commented 2 years ago

other higher priority items came up. I'm at monitorama next week but I'll try to make sure if I have time while there to do any technical work I'll on getting this brushed up.

Here's my plan when i get the round toits to work on this. I'm going to commit this, but I'm going to open up a new PR to add test coverage for the new functions before I tag a release with this change.

echlebek commented 2 years ago

@jspaleta sounds good, but please clean up the merge artifacts in CHANGELOG.md

jspaleta commented 2 years ago

haha... no i totally missed this is MY pr branch... no need for a new PR.. im gonna work in this one. I though this was a PR from a repo fork.

jspaleta commented 2 years ago

@echlebek Okay I have the test coverage sorted out.

In particular I've added test cases for the adjPercent function to make sure its doing the sane expected behavior pushing the percentage threshold limits up/down according to whether the file system is smaller/larger than the "normal" filesystem size.