Closed toozej closed 4 years ago
Nice! This looks good to me. We'll test this this week and merge ASAP. 👍
Looks good to me as well.
@jspaleta how does this look to you?
My team and I want to start using the monitoring plugins on our last few remaining CentOS 6 machines, and having this PR merged and ready to use in Bonsai would make deploying them much easier (IE the same as the rest of our CentOS 7 hosts) :)
updated with feedback from @jspaleta via Sensu Community Slack:
1) use platform_family
instead of platform
so we gain related distros coverage like Ubuntu, etc.
2) use rhel
instead of centos
so we gain additional RHEL coverage "for free"
Resolves #5
Adjusts build.sh to build a CentOS 6 as well as CentOS 7 monitoring-plugins asset. Also sets temporary build containers to remove themselves after assets have been exported, as to not leave "exited" or "/bin/true" containers lying around.
Adds a CentOS 6 Dockerfile, and renames the existing Dockerfile.centos Dockerfile for CentOS 7 to keep filenames consistent.
Fixes a few old references in the README, and adjusts the bonsai configuration to build separate assets for CentOS 6 vs 7.
Signed-off-by: James Tooze toozej@gmail.com