search

sensu / puppet-module-sensuclassic

Puppet module to manage Sensu Classic (ruby version)
MIT License
0 stars 11 forks source link

Add parameter sensuclassic::check::check_name #16

Closed jovrum closed 5 years ago

jovrum commented 5 years ago

Enables definition of multiple checks with the same name; currently the check name is always derived from the check resource name, but this precludes defining multiple checks with the same name on the same host. This is useful when organizing checks into proxy clients, and is maybe useful for general server-side checks as well, where different clients could get a different check configuration based on the subscription, but with the same name. What do you think?

When the new check_name parameter is omitted, it defaults to the same behavior as before.

I am currently using this patch in production on my Sensu deployment, but I haven't added any automated tests to the codebase - please advise if/where it would be sensible.

treydock commented 5 years ago

Opened #19 that is this PR plus also making sensuclassic_check also have check_name for sake of consistency.

jovrum commented 5 years ago

@treydock ah, I missed that completely, and I see you also added tests. Thanks a lot! Should we just close this one in favor of #19?