sensu / puppet-module-sensuclassic

Puppet module to manage Sensu Classic (ruby version)
MIT License
0 stars 11 forks source link

Fix dsc_service order issues #34

Closed treydock closed 4 years ago

treydock commented 4 years ago

Pull Request Checklist

Description

Fix DSC service order of operations.

Related Issue

Fixes #32

Motivation and Context

It seems that dsc_service is starting the service, not Service['sensu-client'] so this ensures that configs and other necessary items are in place before adding the DSC service.

ghoneycutt commented 4 years ago

@treydock travis is failing. Perhaps a dependency needs pinned.

treydock commented 4 years ago

Looks like we need a newer version of rspec-puppet. The issue: https://github.com/rodjek/rspec-puppet/issues/796, the fix: https://github.com/rodjek/rspec-puppet/pull/797, was in rspec-puppet 2.7.9 and we pin to 2.6.x , which won't ever see this necessary fix. I'll update the rspec-puppet dependency.

treydock commented 4 years ago

I've pushed a fix.