search

sensu / sensu-ansible

An Ansible role to deploy a fully dynamic Sensu stack!
https://ansible-sensu.readthedocs.io
MIT License
126 stars 96 forks source link

Changed the ssl generation line to not include 'executable', as it is… #113

Closed tculp closed 6 years ago

tculp commented 6 years ago

… no longer supported in ansible 2.4

Solves issue #101

PaulOstazeski commented 6 years ago

FWIW, I solved this one-off by removing both the underscore and the reference to __bash_path.

tculp commented 6 years ago

@PaulOstazeski

You mean like this?

- name: Generate SSL certs
  command: "{{ sensu_config_path }}/ssl_generation/sensu_ssl_tool/ssl_certs.sh generate"
  args:
      chdir: "{{ sensu_config_path }}/ssl_generation/sensu_ssl_tool"
      creates: "{{ sensu_config_path }}/ssl_generation/sensu_ssl_tool/server"

I believe the original intention of the __bash_path was to allow the user to specify usage of an alternate bash binary

PaulOstazeski commented 6 years ago

Sorry, I should have just pasted this

- name: Generate SSL certs
  command: "{{ sensu_config_path }}/ssl_generation/sensu_ssl_tool/ssl_certs.sh generate"
  args:
    chdir: "{{ sensu_config_path }}/ssl_generation/sensu_ssl_tool"
    creates: "{{ sensu_config_path }}/ssl_generation/sensu_ssl_tool/server"

But you're right, that would remove the capability to use a different bash.