search

sensu / sensu-ansible

An Ansible role to deploy a fully dynamic Sensu stack!
https://ansible-sensu.readthedocs.io
MIT License
126 stars 96 forks source link

Explicitly configure file permissions to support restrictive umask configurations #132

Closed jaredledvina closed 6 years ago

jaredledvina commented 6 years ago

Originally from https://github.com/sensu/sensu-ansible/pull/127

I've nuked the setup of root for the user/group that sensu config directories/files are getting owned to and restored them back to the global default of sensu this aligns with:

Puppet: https://github.com/sensu/sensu-puppet/blob/master/manifests/init.pp#L491 Chef: https://github.com/sensu/sensu-chef/blob/develop/attributes/default.rb#L2-L3

majormoses commented 6 years ago

Is there a reason to remove them rather than specify sensu explicitly?

jaredledvina commented 6 years ago

@majormoses - Mostly because these were the only OS type overrides for this parameter and we already define the default here: https://github.com/sensu/sensu-ansible/blob/master/defaults/main.yml#L78 and https://github.com/sensu/sensu-ansible/blob/master/defaults/main.yml#L73 figured it made more sense to have every OS standardize on the defaults and folks can override it when they deploy the role if they would like to.