search

sensu / sensu-ansible

An Ansible role to deploy a fully dynamic Sensu stack!
https://ansible-sensu.readthedocs.io
MIT License
126 stars 96 forks source link

Add fedora as OS #143

Closed danragnar closed 6 years ago

danragnar commented 6 years ago

This PR allows Fedora to be used in Sensu. At first I only added it as a client OS, but since testing only for client parts seems inconvenient, I added it as a "master" candidate as well as well as a distro in the travis file. I have only tested it here as a client OS, and that's on Fedora 25, so lets see if the tests go through...

jaredledvina commented 6 years ago

Nice, overall this seems legit! Just curious about the wording in the Changelog, thanks so much for the PR! Really happy to see that we could reuse the CentOS logic by switched to package there. I think that's the right call.

danragnar commented 6 years ago

Yea, seemed like the easiest and best way to do it. I'm sure there's a way to reuse/link the rabbit/redis tasks as well by splitting the logic for enabling the epel repo or something like that, but this seems more explicit somehow, in stating the differences between the OS's.

danragnar commented 6 years ago

Thanks! :+1:

jaredledvina commented 6 years ago

Released in version 2.2.0: https://github.com/sensu/sensu-ansible/releases/tag/2.2.0 thanks again!