sensu / sensu-chef

Sensu Chef cookbook.
https://supermarket.chef.io/cookbooks/sensu
Apache License 2.0
221 stars 280 forks source link

Remove hardcoded "Sensu" user and group from _windows.rb install #524

Closed RonTatro closed 7 years ago

RonTatro commented 7 years ago

Expected Behavior

It should use the sensu user and group specified in the attributes instead.

Current Behavior

Current behavior is creating sensu local user accounts regardless of what accounts we are specifying in the attribute overrides.

Possible Solution

Steps to Reproduce (for bugs)

  1. Override default['sensu']['user'] with something other than "sensu"
  2. kitchen converge for a windows platform
  3. Confirm that Sensu local account is created

Context

Creating additional unused user accounts is unnecessary and a security concern. Additionally the code doesn't honor the attribute values in the event you wanted to use something other than sensu.

Your Environment