Update repos to HTTPS - Githubissues

sensu / sensu-chef

Sensu Chef cookbook.

https://supermarket.chef.io/cookbooks/sensu

Apache License 2.0

222 stars 283 forks source link

Update repos to HTTPS #594

Closed thomasriley closed 6 years ago

thomasriley commented 6 years ago

Relates to sensu/sensu-chef#590

Update the repos use for Sensu (non-enterprise) to HTTPS

Description

Updated the default attributes to use the HTTPS repos and updated the Chefspec to validate the URL that is used.

Motivation and Context

Good practice to use HTTPS!

How Has This Been Tested?

Updated the ChefSpec tests to validate the URL I updated in the attributes was indeed HTTPS.

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] My change requires a change to the documentation.
[ ] I have updated the documentation accordingly.
[ ] I have read the CONTRIBUTING document.

majormoses commented 6 years ago

ping @thomasriley

majormoses commented 6 years ago

closing in favor of #602 while there are some advantages of pulling it over https the fact that we now pull the pgp key over https is enough for me.