fix sensu process restarts when are added or modified

[majormoses]

fixes #564

Signed-off-by: Ben Abrams me@benabrams.it

Description

Fixes issues with creating or modifying resources in chef 13, unsure if this breaks compatibility with chef 12 if so we can check the version of chef and depending on the version we can access the appropriate namespace.

Motivation and Context

564

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

• [ ] Bug fix (non-breaking change which fixes an issue)
• [ ] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• [ ] My change requires a change to the documentation.
• [ ] I have updated the documentation accordingly.
• [ ] I have read the CONTRIBUTING document.

[scalp42]

@majormoses took me a while for Chef 12 as it turns out I'm using more Chef 13/Ruby 2.4 features than I thought 🌵

Results on Ubuntu 16.04 (full destroy/converge for each Chef version with sensu_snippet :create => :delete => :create flow) :

Chef v14.0.190:

Without fix:

• it doesnt restart the services on action :create
• it does restart the services on action :delete

With fix:

• it does restart the services on action :create
• it does restart the services on action :delete

Chef v13.8.5:

Without fix:

• it doesnt restart the services on action :create
• it does restart the services on action :delete

With fix:

• it does restart the services on action :create
• it does restart the services on action :delete

Chef v12.22.3:

Without fix:

• it does restart the services on action :create
• it does restart the services on action :delete

With fix:

• it does restart the services on action :create
• it does restart the services on action :delete

TLDR: the PR works as intended 💯

[majormoses]

Thanks for testing!

released: https://supermarket.chef.io/cookbooks/sensu/versions/4.3.1