sensu / sensu-chef

Sensu Chef cookbook.
https://supermarket.chef.io/cookbooks/sensu
Apache License 2.0
222 stars 283 forks source link

serverside cookbooks should be suggested but not required #617

Closed smcavallo closed 5 years ago

smcavallo commented 5 years ago

Signed-off-by: S.Cavallo smcavallo@hotmail.com Addresses https://github.com/sensu/sensu-chef/issues/616

Description

since this cookbook gets applied to both sensu server components (server + api + rabbitmq + redis) and sensu clients, the cookbooks which the server components require should be opted into.

Motivation and Context

allows consumers to opt-in for rabbitmq + redis cookbooks. opting in means that they'll be required to maintain these cookbooks as part of their chef implementation.

How Has This Been Tested?

normal testing as part of the PR process

Screenshots (if appropriate):

Types of changes

This is a breaking change. Since the default is now opt-out, consumers would need to implement the dependency requirements in their wrapper cookbooks.

Checklist:

smcavallo commented 5 years ago

@tas50 - agreed - closing