search

sensu / sensu-chef

Sensu Chef cookbook.
https://supermarket.chef.io/cookbooks/sensu
Apache License 2.0
222 stars 283 forks source link

Yum package versioning is busted #623

Open sspans opened 5 years ago

sspans commented 5 years ago

Yum package versioning is busted because epoch is not used

Expected Behavior

The expected sensu version is installed.

Current Behavior

When upgrading to chef 14, the symptom is continual reinstallations of the sensu package. Which also seems to indicate busted version comparisons for yum_package.

Possible Solution

According to https://github.com/chef/chef/issues/7552 this should be fixed by adding the epoch to the desired version.

Optionally I would suggest installing the package directly, without configuring a yum repository. The current setup breaks when somebody does a 'yum upgrade' because this will pull in newer versions of the sensu packages.

Context

Your Environment

sspans commented 5 years ago

I'll update the issue with a pull-request to fix this tomorrow.

lamont-granquist commented 5 years ago

make sure to test on chef-13 that it takes an epoch, its possible its not backcompatible and you'd need to switch based on chef-client version, i didn't check to see what the old behavior is.

majormoses commented 5 years ago

I would think that we need to replicate this: https://github.com/sensu/sensu-chef/blob/v5.4.0/recipes/_linux.rb#L56-L64 to https://github.com/sensu/sensu-chef/blob/v5.4.0/recipes/_linux.rb#L83-L87 but I don't really have a lot of time to test various platforms and suspect this would break a bunch of old setups.