search

sensu / sensu-go-chef

Chef Library Cookbook for Sensu Go
https://sensu.io
MIT License
11 stars 22 forks source link

Use archive_file resource instead of seven_zip_archive #110

Closed webframp closed 3 years ago

webframp commented 3 years ago

Cookstyle gives the following modernization warning

resources/ctl.rb:75:5: R: ChefModernize/SevenZipArchiveResource: Use the archive_file resource built into Chef Infra Client 15+ instead of the seven_zip_archive

    seven_zip_archive 'Extract Sensuctl Gz' do

    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

resources/ctl.rb:82:5: R: ChefModernize/SevenZipArchiveResource: Use the archive_file resource built into Chef Infra Client 15+ instead of the seven_zip_archive

    seven_zip_archive 'Extract Sensuctl Tar' do

    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Since Chef 15+ is already a requirement in our metadata we should fix this.

webframp commented 3 years ago

example failure https://travis-ci.org/github/sensu/sensu-go-chef/jobs/736683770

majormoses commented 3 years ago

Wondering if we should have something like maintenance or testing label, I would hardly call that this kind of "issue" a bug.

webframp commented 3 years ago

Good idea, I just used the closest thing we had already but happy to use something different

majormoses commented 3 years ago

Any preference on names?

majormoses commented 3 years ago

I think I am more partial to something broad along the lines of Type: Maintenance matching our existing convention.

webframp commented 3 years ago

I think I am more partial to something broad along the lines of Type: Maintenance matching our existing convention.

That sounds reasonable to me