sensu / sensu-go-chef

Chef Library Cookbook for Sensu Go
https://sensu.io
MIT License
11 stars 22 forks source link

Fix sensuctl install and configure for Windows #117

Closed kovukono closed 3 years ago

kovukono commented 3 years ago

Pull Request Checklist

Is this in reference to an existing issue? No

General

New Features

Purpose

sensuctl's first file extract on Windows was being extracted to a different file than was referenced in the second extract.

Windows was downloading the file for sensuctl installation every time without checking to see if it was currently installed.

Windows was having issues with parsing the array of arguments for configuring sensuctl.

Known Compatibility Issues

webframp commented 3 years ago

@kovukono Have you looked at #112 ? It refactors the download process on windows, would you be able to provide some feedback there as well?

kovukono commented 3 years ago

@webframp Unfortunately no. We're using Chef 14, and having to fork the repo to make it work. I can't verify a Chef 15 feature.

webframp commented 3 years ago

@kovukono cookstyle failure in travis shows that this branch doesn't include the fix from #108, could you rebase off of master and update this branch?

I expect that will fix the issue with ci

kovukono commented 3 years ago

@webframp Pulled it in, hopefully it fixes it, but Travis is really slow today. Thanks for the heads up.

webframp commented 3 years ago

Travis is really slow today.

It's been painfully slow all day!

Thanks for the update, I'll review over the weekend.

webframp commented 3 years ago

Fixed the travis annoyance by removing it, #120

webframp commented 3 years ago

Not worried about the markdown lint failures, I'll fix those up on master.