sensu / sensu-go-chef

Chef Library Cookbook for Sensu Go

https://sensu.io

MIT License

11 stars 22 forks source link

sensu_hooks resource #47

Closed derekgroh closed 5 years ago

derekgroh commented 5 years ago

Pull Request Checklist

21

General

[X] Update Changelog following the conventions laid out here
[X] Update README with any necessary configuration snippets
[X] Cookstyle (rubocop) passes
[X] Foodcritic passes
[X] Rspec (unit tests) passes
[X] Inspec (integration tests) passes

New Features

[X] Added a Testing Artifact as either an automated test or a manual artifact on the PR.
[X] Adedd documentation for it to the README.md

Purpose

Create a sensu_hook resource to be used by Chef to create and delete hooks.

Known Compatibility Issues

Unknown

derekgroh commented 5 years ago

Would like to request some assistance on the unit test and artifact testing requirements

majormoses commented 5 years ago

@derekgroh thanks for submitting this, let me first take a quick look and see if I can appease those cops for you. Then lets look at writing a test though I may not have time for the latter until the weekend.

majormoses commented 5 years ago

Well the issue is I don’t have a valid chef_spec, I commented out 55 because it would cause a failure, but wasn’t following the include_examples reference. We can discuss over slack if that’s easier.

I will openly admit I don't touch chef_spec much myself I tend to rely on integration tests over unit tests. I'm gonna go grab dinner and take care of some stuff but feel free to hit me up on slack and we can start hacking when I have the time.

majormoses commented 5 years ago

looks like lints are appeased