adding runtime_assets to sensu_handler provider - Githubissues

sensu / sensu-go-chef

Chef Library Cookbook for Sensu Go

https://sensu.io

MIT License

11 stars 22 forks source link

adding runtime_assets to sensu_handler provider #48

Closed anthonyneto closed 5 years ago

anthonyneto commented 5 years ago

Pull Request Checklist

Is this in reference to an existing issue? No

General

[ ] Update Changelog following the conventions laid out here
[x] Update README with any necessary configuration snippets
[x] Cookstyle (rubocop) passes
[x] Foodcritic passes
[x] Rspec (unit tests) passes
[x] Inspec (integration tests) passes

New Features

[x] Added a Testing Artifact as either an automated test or a manual artifact on the PR.
[x] Adedd documentation for it to the README.md

Purpose

Adding runtime_assets to sensu_handler provider.

Known Compatibility Issues

None

webframp commented 5 years ago

Thanks for your contribution @anthonyneto !

Would it be possible for you to add a test to the file here: https://github.com/sensu/sensu-go-chef/blob/6f74f06dd513c81c931bf96882b0c2f2d99377a6/test/cookbooks/sensu_test/recipes/default.rb#L38 so that we can exercise this property from the integration tests?

You can either extend one of the existing resource definitions or add a new one that has the property.